Is this algorithm and its implementation entirely your own work? If so, first of all, that's awesome! Thanks for the contribution! Second, go ahead and update the license. You'll also need to have a Contributor License Agreement [1] on file with the ASF. I think that covers it. If I'm forgetting something, someone please chime in.
Regards, Matt J [1] https://www.apache.org/licenses/contributor-agreements.html#clas On Tue, Jul 12, 2022 at 4:08 PM Rodion Efremov <codero...@gmail.com> wrote: > > Hello, > > Should I change the license from MIT to Apache License 2.0 before PRing it? > > Best regards, > rodde > > ti 12.7.2022 klo 22.49 Matt Juntunen <matt.a.juntu...@gmail.com> kirjoitti: > > > Thanks! We should be ready for you to put together a PR for this. Have > > we cleared any licensing or copyright issues on this algorithm? I > > can't recall. > > > > Regards, > > Matt J > > > > On Tue, Jul 12, 2022 at 2:06 AM Rodion Efremov <codero...@gmail.com> > > wrote: > > > > > > Hello, > > > > > > I have added the benchmark data (both my and Matt's) to the JIRA issue. > > > Please see the https://issues.apache.org/jira/browse/COLLECTIONS-797 > > > > > > Best regards, > > > rodde > > > > > > On Tue, Jul 12, 2022 at 2:34 AM Alex Herbert <alex.d.herb...@gmail.com> > > > wrote: > > > > > > > On Mon, 11 Jul 2022 at 17:16, Gilles Sadowski <gillese...@gmail.com> > > > > wrote: > > > > > > > > > Le lun. 11 juil. 2022 à 09:51, Rodion Efremov <codero...@gmail.com> > > a > > > > > écrit : > > > > > > > > > > > > Hi Gilles, > > > > > > > > > > > > Would it be sufficient to include .txt files for the tables and the > > > > .ods > > > > > > file provided by Matt? > > > > > > > > > > It would be more handy for readers that tables are inserted "inline" > > > > > within a comment (using the JIRA syntax) and plots are uploaded > > > > > as PNG images. See e.g. this report: > > > > > https://issues.apache.org/jira/browse/NUMBERS-156 > > > > > > > > > > > > Note that the Jira web editor will accept a table copied from > > > > Excel/OpenOffice and pasted in when in 'Visual' mode. You can then > > switch > > > > from 'Visual' to 'Text' mode to see the raw JIRA syntax and make > > changes to > > > > improve the layout. The 'Visual' mode has some editor buttons to > > manipulate > > > > the table. > > > > > > > > Alex > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
