[
https://issues.apache.org/jira/browse/COMMONSRDF-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539658#comment-14539658
]
ASF GitHub Bot commented on COMMONSRDF-21:
------------------------------------------
GitHub user stain opened a pull request:
https://github.com/apache/incubator-commonsrdf/pull/15
COMMONSRDF-21 No BlankNode requirements in createGraph()
Fixes [COMMONSRDF-21](https://issues.apache.org/jira/browse/COMMONSRDF-21)
by removing the requirement for `BlankNode` mapping for the returned `Graph`'s
`createGraph()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stain/incubator-commonsrdf
COMMONSRDF-21-createGraph-requirements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-commonsrdf/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 5dd7d16eac97362e29f2583c99e6b412532c8ef1
Author: Stian Soiland-Reyes <[email protected]>
Date: 2015-05-12T11:03:38Z
COMMONSRDF-21 No BlankNode requirements in createGraph()
Fixes COMMONSRDF-21 by
removing the requirement for BlankNode mapping for the returned
Graph's createGraph().
----
> Remove BlankNode requirements from RDFTermFactory.createGraph()
> ---------------------------------------------------------------
>
> Key: COMMONSRDF-21
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-21
> Project: Apache Commons RDF
> Issue Type: Improvement
> Affects Versions: 0.1
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Fix For: 0.2
>
>
> [RDFTermFactory.createGraph|http://commonsrdf.incubator.apache.org/apidocs/org/apache/commons/rdf/api/RDFTermFactory.html#createGraph--]
>
> says:
> > BlankNode objects added to the Graph returned from this method SHOULD be
> > mapped using the createBlankNode(String) of this factory, called using the
> > BlankNode.uniqueReference() as the parameter, before they are inserted into
> > the Graph.
> I suggest to remove this paragraph as it is very specific, and I disagree on
> the need for such a mapping. It is also strange for the RDFTermFActory to put
> requirements on later calls on the methods of Graph. The pattern of calling
> createBlankNode with a uniqueReference() is not shown elsewhere.
> Note that simple does such a mapping, so this bug would also imply to change
> this:
> https://github.com/apache/incubator-commonsrdf/blob/master/simple/src/main/java/org/apache/commons/rdf/simple/GraphImpl.java#L81
> .. but I think COMMONSRDF-15 should decide on that matter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
