[
https://issues.apache.org/jira/browse/COMMONSRDF-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535739#comment-15535739
]
ASF GitHub Bot commented on COMMONSRDF-35:
------------------------------------------
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/24#discussion_r81321953
--- Diff:
rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/RDF4JDataset.java ---
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.rdf.rdf4j;
+
+import org.apache.commons.rdf.api.Dataset;
+import org.apache.commons.rdf.api.Quad;
+
+
+/**
+ * Marker interface for RDF4J implementations of Dataset.
+ *
+ */
+public interface RDF4JDataset extends Dataset, RDF4JGraphLike<Quad> {
--- End diff --
[GraphLike](http://stain.github.io/incubator-commonsrdf/COMMONSRDF-35/org/apache/commons/rdf/api/GraphLike.html)
is the common interface between `Graph` and `Dataset` - operating over
`TripleLike` entries.
This is mainly useful for general code that can deal with both graph and
dataset (e.g. a parser/writer that iterates over `TripleLike`) - a `Graph` and
`Dataset` would have different equality semantics on operations like
`.contains()` and `remove()`.
We might not need a corresponding
[RDF4JGraphLike](http://stain.github.io/incubator-commonsrdf/COMMONSRDF-35/org/apache/commons/rdf/rdf4j/RDF4JGraphLike.html)
- it exposes `.asModel()` and `asRepository()`.
Internally in `rdf4j/` there's an abstract class
[AbstractRepositoryGraphLike](http://stain.github.io/incubator-commonsrdf/COMMONSRDF-35/org/apache/commons/rdf/rdf4j/impl/AbstractRepositoryGraphLike.html)
which shares the code of
[RepositoryDatasetImpl](http://stain.github.io/incubator-commonsrdf/COMMONSRDF-35/org/apache/commons/rdf/rdf4j/impl/RepositoryDatasetImpl.html)
(implementing `Dataset`) and
[RepositoryGraphImpl](http://stain.github.io/incubator-commonsrdf/COMMONSRDF-35/org/apache/commons/rdf/rdf4j/impl/RepositoryGraphImpl.html)
(implementing `Graph`).
> rdf4j integration
> -----------------
>
> Key: COMMONSRDF-35
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-35
> Project: Apache Commons RDF
> Issue Type: New Feature
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Labels: integration, rdf4j, sesame
> Fix For: 0.3.0
>
>
> Add a new rdf4j module with implementation for Eclipse rdf4j
> See https://github.com/apache/incubator-commonsrdf/tree/rdf4j/rdf4j
> A legacy sesame branch could then be added by mainly copy/paste and change
> the import
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
