[
https://issues.apache.org/jira/browse/COMMONSRDF-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535745#comment-15535745
]
ASF GitHub Bot commented on COMMONSRDF-35:
------------------------------------------
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/24#discussion_r81322365
--- Diff: rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/RDF4JGraph.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.rdf.rdf4j;
+
+import java.util.Optional;
+
+import org.apache.commons.rdf.api.Graph;
+import org.apache.commons.rdf.api.Triple;
+import org.apache.commons.rdf.rdf4j.impl.ModelGraphImpl;
+import org.apache.commons.rdf.rdf4j.impl.RepositoryGraphImpl;
+import org.eclipse.rdf4j.model.Model;
+import org.eclipse.rdf4j.model.Resource;
+import org.eclipse.rdf4j.repository.Repository;
+
+
+/**
+ * Marker interface for RDF4J implementations of Graph.
+ *
+ * @see ModelGraphImpl
+ * @see RepositoryGraphImpl
+ */
+public interface RDF4JGraph extends Graph, RDF4JGraphLike<Triple> {
+
+ /**
+ * Return a copy of the context filter, if present.
+ * <p>
+ * If {@link Optional#isPresent()}, the filter determines which
+ * <em>contexts</em> in the corresponding RDF4J {@link Model} or
+ * {@link Repository} that this graph reflect. Modifications to the
graph
+ * (e.g. {@link #add(Triple)} will be performed for all the specified
+ * contexts, while retrieval (e.g. {@link #contains(Triple)}) will
succeed
+ * if the triple is in at least one of the specified contexts.
+ * <p>
+ * The context filter array may contain <code>null</code>, indicating
the
+ * default context (the <em>default graph</em> in RDF datasets).
+ * <p>
+ * If the context filter is {@link Optional#empty()}, then this is a
+ * <em>union graph</em> which triples reflecting statements in any
contexts.
+ * Triples added to the graph will be added in the default context
+ * <code>null</code>.
--- End diff --
Yes, this was very confusing from RDF4J's API as I am not sure where the
nulls are allowed and how adding to the default graph should be best done - I
understood it that it needs to be an a `new Resource[]{null}` array, not just
`null`.
(When calling the varargs you would need to cast as `(Resource)null` or
make the array explicitly to get it right)
> rdf4j integration
> -----------------
>
> Key: COMMONSRDF-35
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-35
> Project: Apache Commons RDF
> Issue Type: New Feature
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Labels: integration, rdf4j, sesame
> Fix For: 0.3.0
>
>
> Add a new rdf4j module with implementation for Eclipse rdf4j
> See https://github.com/apache/incubator-commonsrdf/tree/rdf4j/rdf4j
> A legacy sesame branch could then be added by mainly copy/paste and change
> the import
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
