Github user ansell commented on a diff in the pull request:

    https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85232426
  
    --- Diff: 
api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java ---
    @@ -67,7 +67,7 @@
         protected Literal companyName;
         protected Triple bobNameTriple;
     
    -    public abstract RDFTermFactory createFactory();
    +    public abstract RDF createFactory();
    --- End diff --
    
    Also, this method only needs to be protected, not public, to emphasise that 
it is not accessible from third-parties other than those that override this 
class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to