Github user ansell commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85232493
--- Diff:
api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTermFactoryTest.java ---
@@ -29,26 +29,26 @@
import org.junit.Test;
/**
- * Test RDFTermFactory implementation (and thus its RDFTerm
implementations)
+ * Test RDF implementation (and thus its RDFTerm implementations)
* <p>
* To add to your implementation's tests, create a subclass with a name
ending
* in <code>Test</code> and provide {@link #createFactory()} which
minimally
* supports one of the operations, but ideally supports all operations.
*
- * @see RDFTermFactory
+ * @see RDF
*/
public abstract class AbstractRDFTermFactoryTest {
- private RDFTermFactory factory;
+ private RDF factory;
/**
- * testCreate a new, distinct {@link RDFTermFactory} object using the
+ * testCreate a new, distinct {@link RDF} object using the
* implementation being tested here.
*
- * @return a new, distinct {@link RDFTermFactory} object using the
+ * @return a new, distinct {@link RDF} object using the
* implementation being tested here
*/
- public abstract RDFTermFactory createFactory();
+ public abstract RDF createFactory();
--- End diff --
Ditto on this method only needing to be protected, not public, to emphasise
its internal use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
