Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85524961
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFTermFactory.java
---
@@ -17,262 +17,61 @@
*/
package org.apache.commons.rdf.api;
-import java.io.Serializable;
-import java.util.Locale;
-
/**
- * Factory for creating RDFTerm and Graph instances.
- * <p>
- * It is not specified how an implementation should provide a
RDFTermFactory.
- * <p>
- * If an implementation does not support a particular method (e.g. it
requires
- * additional parameters or can't create graphs), then it MAY throw
- * {@link UnsupportedOperationException}, as provided by the
<code>default</code>
- * implementations in this interface.
+ * Factory for creating RDFTerm instances..
* <p>
- * If a factory method does not allow or support a provided parameter, e.g.
- * because an IRI is considered invalid, then it SHOULD throw
- * {@link IllegalArgumentException}.
- *
- * @see RDFTerm
- * @see Graph
- * @see Quad
+ * This interface is <strong>deprecated</strong> in favour of
+ * the richer {@link RDF}.
+ *
+ * @see RDF
*/
+@Deprecated
public interface RDFTermFactory {
- /**
- * Create a new blank node.
- * <p>
- * The returned blank node MUST NOT be equal to any existing
- * {@link BlankNode} instances according to {@link
BlankNode#equals(Object)}.
- *
- * @return A new, unique {@link BlankNode}
- * @throws UnsupportedOperationException
- * If the operation is not supported.
- */
default BlankNode createBlankNode() throws
UnsupportedOperationException {
--- End diff --
Maybe we could have a specific marker interface for that `PartialRDF` <
`RDF`? Or a test method `default boolean isComplete() {return false;}`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
