Actually I do not understand the use case at all. Never mind. I was just pointing out possible pitfalls on different platforms.
I think it is ok to have platform specific delimiters: ; for windows and : for unix-like That would follow common practices on those platforms; although I always shudder when (semi-)colon delimited lists are proposed. I will probably never use this parameter because I know where the plugin is that I want to add/remove. I have an build.xml for ant that adds all the plugins my project needs. Remove is used when I develop a plugin and do not want to do a "ant dist-clean". -Axel 2014/1/8 Mark Koudritsky <[email protected]> > Good point, there is no need for delimiters in config.json anyway. > Do you think it's worth the extra code to introduce the platform specific > delimiter logic for the command line? > > > On Wed, Jan 8, 2014 at 3:08 PM, Axel Nennker <[email protected]> > wrote: > > > If it searchpath is in cordova.json then it could/should be an array, > > right? > > > > { > > ... > > "searchpath": ["c:\myplugins", "z:\sharedplugins"], > > ... > > } > > > > > > 2014/1/8 Mark Koudritsky <[email protected]> > > > > > I think the use of searchpath as command line param will be rare, in > most > > > cases it will be stored in some config file (e.g. cordova.json) and it > > > would be much better to keep it there in a platform independent format. > > > > > > > > > On Wed, Jan 8, 2014 at 2:28 PM, Jesse <[email protected]> wrote: > > > > > > > I think we should be using semi-colon as a delim when in a windows > > > > environment, and colon in unix. > > > > > > > > Having multiple --searchpath flags on top of that is just extra sugar > > in > > > my > > > > opinion. > > > > > > > > Just like the system path ... > > > > > > > > > > > > > > > > @purplecabbage > > > > risingj.com > > > > > > > > > > > > On Wed, Jan 8, 2014 at 11:15 AM, Mark Koudritsky <[email protected]> > > > wrote: > > > > > > > > > > > > > > ----------------------------------------------------------- > > > > > This is an automatically generated e-mail. To reply, visit: > > > > > https://reviews.apache.org/r/16739/ > > > > > ----------------------------------------------------------- > > > > > > > > > > Review request for cordova. > > > > > > > > > > > > > > > Bugs: CB-5006 > > > > > https://issues.apache.org/jira/browse/CB-5006 > > > > > > > > > > > > > > > Repository: cordova-plugman > > > > > > > > > > > > > > > Description > > > > > ------- > > > > > > > > > > Same diff on github: > > > > > https://github.com/kamrik/cordova-plugman/compare/sp2 > > > > > > > > > > > > > > > The colon can't be used as delimiter for Windows paths because > > > > > they already contain colons e.g. C:\my_plugins > > > > > Instead of using a delimiter, this change allows to repeat the > > > > > --searchpath flag for each additional directory to be searched. > > > > > The value for each path is resolved relative to the current dir. > > > > > Example: > > > > > --searchpath ../my_plugins --searhcpath /usr/lib/other_plugins > > > > > > > > > > The dirs are searched in order. Search is not recursive and will > only > > > > > look one level down. It will look for > > > > > my_plugins/plugin_x/plugin.xml > > > > > but not for > > > > > my_plugins/bunch_of_plugins/plugin_y/plugin.xml > > > > > > > > > > > > > > > Diffs > > > > > ----- > > > > > > > > > > doc/help.txt 1ab3467 > > > > > main.js 877c563 > > > > > plugman.js 4c0f61b > > > > > > > > > > Diff: https://reviews.apache.org/r/16739/diff/ > > > > > > > > > > > > > > > Testing > > > > > ------- > > > > > > > > > > npm test > > > > > plugman (un)install > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Mark Koudritsky > > > > > > > > > > > > > > > > > > > >
