----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16739/ -----------------------------------------------------------
(Updated Jan. 14, 2014, 5:33 a.m.) Review request for cordova. Changes ------- Minor fixes needed while plumbing into cordova-cli As this feature will be mostly used via config files or scripts: * Leaving the long but descriptive tag as it was --searchpath. * Using repeated tag for specifying multiple dirs. The occasional use of the flag on command line does not justify the extra logic for platform dependent delimiter. Cordova-cli change for --searchpath is here: https://reviews.apache.org/r/16854/ Bugs: CB-5006 https://issues.apache.org/jira/browse/CB-5006 Repository: cordova-plugman Description ------- Same diff on github: https://github.com/kamrik/cordova-plugman/compare/sp2 The colon can't be used as delimiter for Windows paths because they already contain colons e.g. C:\my_plugins Instead of using a delimiter, this change allows to repeat the --searchpath flag for each additional directory to be searched. The value for each path is resolved relative to the current dir. Example: --searchpath ../my_plugins --searhcpath /usr/lib/other_plugins The dirs are searched in order. Search is not recursive and will only look one level down. It will look for my_plugins/plugin_x/plugin.xml but not for my_plugins/bunch_of_plugins/plugin_y/plugin.xml Diffs (updated) ----- doc/help.txt 1ab3467 main.js 877c563 plugman.js 4c0f61b src/fetch.js 2f45f5f Diff: https://reviews.apache.org/r/16739/diff/ Testing ------- npm test plugman (un)install Thanks, Mark Koudritsky
