Thanks, I was waiting for Andrew's approval. Issue #CB-6745, opened and closed
@purplecabbage risingj.com On Fri, May 23, 2014 at 7:42 AM, Andrew Grieve <agri...@chromium.org> wrote: > Yes, should be safe to remove the flag. > > > On Thu, May 22, 2014 at 7:58 PM, Michal Mocny <mmo...@chromium.org> wrote: > > > I just removed them locally and you are right, they are no longer needed. > > SGTM. > > > > > > On Thu, May 22, 2014 at 7:43 PM, Jesse <purplecabb...@gmail.com> wrote: > > > > > coho has the --harmony-generators directly in the coho bash script [1], > > and > > > the coho.cmd file. [2] > > > > > > On windows, I need to remove --harmony-generators from [1] if I am > > running > > > from a git-bash terminal, and from [2] if I am running from cmd. Both > > break > > > execution in node v0.10.22, so I would like to remove them so we can > all > > > run the same thing. > > > Other than that, everything seems fine. > > > > > > > > > [1] https://github.com/apache/cordova-coho/blob/master/coho#L1 > > > [2] https://github.com/apache/cordova-coho/blob/master/coho.cmd#L1 > > > > > > > > > > > > @purplecabbage > > > risingj.com > > > > > > > > > On Thu, May 22, 2014 at 4:29 PM, Michal Mocny <mmo...@chromium.org> > > wrote: > > > > > > > RE: gnode, Awesome. > > > > > > > > RE: --harmony-generators, not sure what you mean. Did you add that > > > > manually to your local node flags? I no longer need to do anything > to > > my > > > > environment for coho to run, and I don't much care that coho uses > magic > > > > from the future. > > > > > > > > -Michal > > > > > > > > > > > > On Thu, May 22, 2014 at 6:03 PM, Jesse <purplecabb...@gmail.com> > > wrote: > > > > > > > > > gnode seems good on windows > > > > > Can I remove the --harmony-generators then? > > > > > > > > > > Or do I need to make a new root command? > > > > > noho, windoho, woho, fauxho ? > > > > > > > > > > > > > > > @purplecabbage > > > > > risingj.com > > > > > > > > > > > > > > > On Thu, May 22, 2014 at 2:47 PM, Michal Mocny <mmo...@chromium.org > > > > > > wrote: > > > > > > > > > > > ..but I haven't tested gnode on windows, sorry. > > > > > > > > > > > > > > > > > > On Thu, May 22, 2014 at 5:47 PM, Michal Mocny < > mmo...@chromium.org > > > > > > > > wrote: > > > > > > > > > > > > > I no longer use node 0.11 and coho runs fine on 0.10 thanks to > > > gnode. > > > > > > > > > > > > > > nvm/nave aren't necessary at all (I think), especially now that > > we > > > > > don't > > > > > > > need to switch node versions just for coho, they are just > > > convenient > > > > if > > > > > > you > > > > > > > want to jump around environments or lack permissions to do > global > > > > > > installs. > > > > > > > > > > > > > > Yes, I think node 0.11 was needed for coroutines (function*()) > > and > > > > > yield, > > > > > > > I'm not sure if other es6 features were used. > > > > > > > > > > > > > > -Michal > > > > > > > > > > > > > > > > > > > > > On Thu, May 22, 2014 at 5:28 PM, Jesse < > purplecabb...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > >> Reviving this thread ... > > > > > > >> > > > > > > >> ping! > > > > > > >> Is the only reason we depend on node v0.11 to support 'yield'? > > > > > > >> also: > > > > > > >> Has anyone managed to run this on windows? Not having good > luck > > > with > > > > > > nave > > > > > > >> or nvm .... > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> @purplecabbage > > > > > > >> risingj.com > > > > > > >> > > > > > > >> > > > > > > >> On Thu, May 15, 2014 at 9:40 AM, Steven Gill < > > > > stevengil...@gmail.com> > > > > > > >> wrote: > > > > > > >> > > > > > > >> > Don't you guys just love these dropped emails :) > > > > > > >> > On May 15, 2014 6:47 AM, "Brian LeRoux" <b...@brian.io> wrote: > > > > > > >> > > > > > > > >> > > > https://github.com/TooTallNate/gnode/blob/master/README.md > > > > > > >> > > On May 7, 2014 1:18 PM, "Michal Mocny" < > mmo...@chromium.org > > > > > > > > wrote: > > > > > > >> > > > > > > > > >> > > > Damnit. Perplexing choice. Coho isn't released to end > > > users, > > > > > and > > > > > > >> the > > > > > > >> > > > codebase is tremendously cleaner and more maintainable > > now. > > > > On > > > > > > the > > > > > > >> > other > > > > > > >> > > > hand, doing release testing using development version of > > > node > > > > > does > > > > > > >> seem > > > > > > >> > > > odd. > > > > > > >> > > > > > > > > > >> > > > One possible solution, for now, is nvm supports changing > > the > > > > > > version > > > > > > >> > for > > > > > > >> > > a > > > > > > >> > > > given terminal session only (nvm use). Can leave your > > > default > > > > > > node > > > > > > >> to > > > > > > >> > > > 0.10, and you can use a dedicated terminal for using > coho. > > > > > Longer > > > > > > >> > term, > > > > > > >> > > > I'm not sure. Hope node 0.12 ships soon? > > > > > > >> > > > > > > > > > >> > > > -Michal > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > On Tue, May 6, 2014 at 7:15 PM, Anis KADRI < > > > > > anis.ka...@gmail.com> > > > > > > >> > wrote: > > > > > > >> > > > > > > > > > >> > > > > I got excited and tried to use the latest version of > > coho > > > > but > > > > > > >> when I > > > > > > >> > > saw > > > > > > >> > > > > that it was using an odd version I just gave up. > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > On Tue, May 6, 2014 at 4:11 PM, Steven Gill < > > > > > > >> stevengil...@gmail.com> > > > > > > >> > > > > wrote: > > > > > > >> > > > > > > > > > > >> > > > > > Thanks for sharing Martin! > > > > > > >> > > > > > > > > > > > >> > > > > > I also am on the train that we shouldn't be using > > > unstable > > > > > > >> versions > > > > > > >> > > of > > > > > > >> > > > > > node. I don't know if the landscape has changed > since > > I > > > > > > started > > > > > > >> > using > > > > > > >> > > > > node, > > > > > > >> > > > > > but I was always taught to stick to even version > > > numbers. > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > On Tue, May 6, 2014 at 4:03 PM, Martin Gonzalez > Glez < > > > > > > >> > > > > > martin.c.glez.g...@gmail.com> wrote: > > > > > > >> > > > > > > > > > > > >> > > > > > > Agree guys we shouldn't be depending on unstable > > node > > > > > > >> versions to > > > > > > >> > > > work, > > > > > > >> > > > > > > just sharing what it worked for me. I think coho > has > > > > been > > > > > > >> using > > > > > > >> > > node > > > > > > >> > > > > 0.11 > > > > > > >> > > > > > > since the last clean up a few days ago. > > > > > > >> > > > > > > > > > > > > >> > > > > > > Hey Joe, I've just shared with you my findings, > it's > > > not > > > > > the > > > > > > >> best > > > > > > >> > > > > > solution > > > > > > >> > > > > > > I know that, but it worked for me. > > > > > > >> > > > > > > On May 6, 2014 5:47 PM, "Jesse" < > > > > purplecabb...@gmail.com> > > > > > > >> wrote: > > > > > > >> > > > > > > > > > > > > >> > > > > > > > We shouldn't be depending on unstable versions > of > > > > node, > > > > > > imo. > > > > > > >> > > > > > > > Being able to switch versions is not a solution. > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > @purplecabbage > > > > > > >> > > > > > > > risingj.com > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > On Tue, May 6, 2014 at 3:40 PM, Martin Gonzalez > > > Glez < > > > > > > >> > > > > > > > martin.c.glez.g...@gmail.com> wrote: > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > I had the same problem with nodejs 0.11, using > > > > > url.parse > > > > > > >> > > module & > > > > > > >> > > > > and > > > > > > >> > > > > > > > > running the Unit Test on cordova-js, those are > > > > failing > > > > > > >> with > > > > > > >> > > > nodejs > > > > > > >> > > > > > > > 0.11.13, > > > > > > >> > > > > > > > > but with 0.11.12 it works fine. > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > Nodejs 0.11 it's working unestable, they are > > going > > > > to > > > > > > >> release > > > > > > >> > > one > > > > > > >> > > > > > more > > > > > > >> > > > > > > > > 11.xx version before nodejs 0.12 (According to > > > their > > > > > > >> google > > > > > > >> > > group > > > > > > >> > > > > > > forum). > > > > > > >> > > > > > > > > It seems that cordova-coho uses a dependency > > that > > > > > > requires > > > > > > >> > node > > > > > > >> > > > > 0.11. > > > > > > >> > > > > > > > > A quick fix in your case Joe it's the usage > of a > > > > node > > > > > > >> version > > > > > > >> > > > > manager > > > > > > >> > > > > > > as > > > > > > >> > > > > > > > > "n" or "nvm" for Mac OS X, or nodist under > > > Windows. > > > > > > >> > > > > > > > > It won't fix your nodejs 11, but it allows you > > to > > > > > switch > > > > > > >> > > between > > > > > > >> > > > > > nodejs > > > > > > >> > > > > > > > > versions easily and quickly. > > > > > > >> > > > > > > > > On May 6, 2014 5:07 PM, "Joe Bowser" < > > > > > bows...@gmail.com > > > > > > > > > > > > > >> > > wrote: > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > Hey > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > I know that for some reason, we decided to > use > > > > node > > > > > > 0.11 > > > > > > >> > for > > > > > > >> > > > > coho, > > > > > > >> > > > > > > but > > > > > > >> > > > > > > > > > the thing is that it means that we can't run > > the > > > > > Unit > > > > > > >> Tests > > > > > > >> > > on > > > > > > >> > > > > > > > > > cordova-js now. At least on my machine, > coho > > > will > > > > > now > > > > > > >> > always > > > > > > >> > > > > fail > > > > > > >> > > > > > > > > > because of either named branch errors or > Unit > > > Test > > > > > > >> errors. > > > > > > >> > > > This > > > > > > >> > > > > > > seems > > > > > > >> > > > > > > > > > to be some weird unicode enforcing that is > > > > happening > > > > > > in > > > > > > >> the > > > > > > >> > > > node > > > > > > >> > > > > > > 0.11. > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > This is extremely frustrating, since we're > > > > supposed > > > > > to > > > > > > >> use > > > > > > >> > > this > > > > > > >> > > > > > coho > > > > > > >> > > > > > > > > > tool to do releases to automate the process, > > yet > > > > the > > > > > > >> tool > > > > > > >> > > keeps > > > > > > >> > > > > > > > > > breaking every time we try and use it. I'm > > sure > > > > > that > > > > > > >> > > there's a > > > > > > >> > > > > > whole > > > > > > >> > > > > > > > > > other thread where this issue was beaten to > > > death, > > > > > > but I > > > > > > >> > > didn't > > > > > > >> > > > > > need > > > > > > >> > > > > > > > > > to try to tag an RC1 for 3.5 when that was > > > > > happening. > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > Seriously, can we make coho work with stable > > > node > > > > > > >> versions, > > > > > > >> > > or > > > > > > >> > > > > > agree > > > > > > >> > > > > > > > > > to stop using it altogether and re-write the > > > docs > > > > on > > > > > > >> > cutting > > > > > > >> > > a > > > > > > >> > > > > > > > > > release? I probably will have to do RC1 > > > manually > > > > > > >> because > > > > > > >> > of > > > > > > >> > > > how > > > > > > >> > > > > > > > > > broken it is right now. > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
