Github user kamrik commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/15#discussion_r13134502
  
    --- Diff: cordova-lib/src/plugman/util/config-changes.js ---
    @@ -510,8 +509,7 @@ function ConfigFile_load() {
             self.data = xml_helpers.parseElementtreeSync(filepath);
         } else if (ext == '.pbxproj') {
             self.type = 'pbxproj';
    -        self.data = xcode.project(filepath);
    -        self.data.parseSync();
    +        self.data = platforms.ios.parseProjectFile(self.project_dir).xcode;
    --- End diff --
    
    I switched to directly using xcode here instead of parseProjectFile() here 
several months ago. The reason was speed. parseProjectFile() has a pretty slow 
blob call as one of the first lines (order of 50-100ms).
    
    Is there any functional reason you want to use parseProjectFile here other 
than elegance? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to