Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/15#discussion_r13135935
--- Diff: cordova-lib/src/plugman/util/config-changes.js ---
@@ -510,8 +509,7 @@ function ConfigFile_load() {
self.data = xml_helpers.parseElementtreeSync(filepath);
} else if (ext == '.pbxproj') {
self.type = 'pbxproj';
- self.data = xcode.project(filepath);
- self.data.parseSync();
+ self.data = platforms.ios.parseProjectFile(self.project_dir).xcode;
--- End diff --
It was part of a larger optimization to speed up "cordova prepare" during
which lots of files were re-parsed several times (once per plugin). Looks like
we introduced both changes at about the same time (Jan/Feb) this resulted in
double caching and overwriting. Before the two of our changes the extra glob
was executed per plugin during prepare and was one of the largest time wasters.
Anyway, right now the glob will only run once so it's not a big deal.
LGTM. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
