Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r22904360
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -354,22 +359,94 @@ describe('add function', function () {
});
});
- it('fails if there is an error while getting the platform details',
function (done) {
+ it('tries to git-clone if there is an error while getting the platform
details as specified from the command line', function (done) {
- var targets = ['C:\\Projects\\cordova-projects\\cordova-android'];
+ var targets = ['https://github.com/apache/cordova-android'],
+ targetPlatform = 'android',
+ libDir =
'C:\\Projects\\cordova-projects\\cordova-android-clone-directory';
+
+ var cloneGitRepoMock = jasmine.createSpy().andReturn(Q({
+ platform: targetPlatform,
+ libDir: libDir
+ }));
+ platform.__set__('cloneGitRepo', cloneGitRepoMock);
--- End diff --
@jsoref , why do I still need a PR to update
https://github.com/apache/cordova-cli/blob/38dd67242841dd2ec254f7f9f402f495f7a28f5b/doc/platform.txt#L20
?
It seems like the file already refers to <url>s
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
