Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r23408256
  
    --- Diff: cordova-lib/src/cordova/util.js ---
    @@ -55,6 +61,8 @@ exports.preProcessOptions = preProcessOptions;
     exports.addModuleProperty = addModuleProperty;
     exports.getOrigWorkingDirectory = getOrigWorkingDirectory;
     exports.fixRelativePath = fixRelativePath;
    +exports.getPlatformDetailsFromDir = getPlatformDetailsFromDir;
    --- End diff --
    
    "util" is generally a place where code factoring is low because people dump 
into it. I think this case applies - you should create a new module for the git 
cloning. Don't care where you put it though. Maybe call it "gitclone.js"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to