You may or may not, but I think it would be nice to let others review your (significant) changes before dumping them to master.
> On Feb 11, 2015, at 6:34 PM, Andrew Grieve <agri...@chromium.org> wrote: > >> On Wed, Feb 11, 2015 at 5:00 PM, Jesse <purplecabb...@gmail.com> wrote: >> >> +1 Revert >> >> And please let's stop deleting what other people wrote just because we >> don't recognize it. These things should require discussion. > > Bit of a jump to conclusions, don't you think? What makes you think I don't > recognize the code I changed? > > >> >> @purplecabbage >> risingj.com >> >>> On Wed, Feb 11, 2015 at 1:53 PM, Joe Bowser <bows...@gmail.com> wrote: >>> >>> I think we should revert this refactor. With the new refactored tests, >>> they may pass but we lost a lot of the useful tests that we once had and >>> these new tests have no value. I don't know why you took it upon >> yourself >>> to throw away all the JUnit tests that didn't pass, but that misses the >>> point. I would have rather had the old tests expanded upon instead of >> just >>> deleted on your personal whim. >>> >>> I honestly don't know what to say, I know that we have a terrible working >>> relationship at best, but this actually is making the project worse >>> intentionally for unknown reasons. In fact, I would almost say that this >>> is purely a malicious change driven by ego, since I can't see a technical >>> reason for any of it. >>> >>>> On Wed Feb 11 2015 at 1:36:19 PM Joe Bowser <bows...@gmail.com> wrote: >>>> >>>> I think there's a lot of value in the Unit Tests, having wrote the >>>> majority of them initially. If I wasn't dealing with everyone in my >>> house >>>> getting sick, I'd check to make sure these tests were still testing >> what >>> I >>>> intended them to test, since we have a habit of losing the intent >> behind >>>> the test every time we do a refactor. >>>> >>>> Of course, if we're going to throw away the embedded WebView case, then >>>> maybe there's not value after all. >>>> >>>> On Wed Feb 11 2015 at 1:12:29 PM Andrew Grieve <agri...@chromium.org> >>>> wrote: >>>> >>>>> Does travis provide Android emulators? I'd guess it'd be too slow to >> put >>>>> on >>>>> Travis. And honestly, there's still not a lot of value in the unit >> tests >>>>> atm. >>>>> >>>>> On Wed, Feb 11, 2015 at 3:12 PM, Murat Sutunc <mura...@microsoft.com> >>>>> wrote: >>>>> >>>>>> This is great news! >>>>>> I've finally got the android travis enabled too. We have jshint and >>>>>> jasmine test coverage on every commit now. ( >>>>>> https://travis-ci.org/apache/cordova-android/builds/50295748) >>>>>> >>>>>> Now that we're passing all junit tests, I think the next step for us >>>>>> should be to integrate junit tests with travis. What do you think? >>>>>> >>>>>> -----Original Message----- >>>>>> From: agri...@google.com [mailto:agri...@google.com] On Behalf Of >>>>> Andrew >>>>>> Grieve >>>>>> Sent: Tuesday, February 10, 2015 7:14 PM >>>>>> To: dev >>>>>> Subject: Android JUnit Tests Now Pass >>>>>> >>>>>> Spent some time cleaning up the tests. Certainly they could be made >>> even >>>>>> better & made to test more things, but at least they pass now :) >>>>>> >>>>>> Much of the change was deleting copy & paste, and deleting commented >>> out >>>>>> tests: >>>>>> 53 files changed, 941 insertions(+), 2610 deletions(-) >> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>>>>> For additional commands, e-mail: dev-h...@cordova.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
