Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/383#discussion_r52782123
--- Diff: cordova-lib/src/cordova/create.js ---
@@ -191,8 +191,8 @@ function create(dir, optionalId, optionalName, cfg) {
return remoteLoad.gitClone(gitURL, branch).fail(
function(err) {
- events.emit('verbose', err);
- return Q.reject('Failed to retrieve '+
cfg.lib.www.url + ' using git.');
+ events.emit('warn', err.message);
+ return Q.reject(new CordovaError('Failed to
retrieve '+ cfg.lib.www.url + ' using git.'));
--- End diff --
Should the `err.message` be appended to new CordovaError or the original
`err` be passed as inner error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
