Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/383#discussion_r52782786
--- Diff: cordova-lib/src/cordova/compile.js ---
@@ -40,7 +40,7 @@ module.exports = function compile(options) {
}).then(function() {
return hooksRunner.fire('after_compile', options);
}, function(error) {
- events.emit('log', 'ERROR building one of the platforms: ' + error
+ '\nYou may not have the required environment or OS to build this project');
+ events.emit('warn', 'ERROR building one of the platforms: ' +
error + '\nYou may not have the required environment or OS to build this
project');
--- End diff --
Also when should one use `events.emit('error', ...)` For all errors now we
are using warning - this is confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
