Why do you think that binding is required after "deviceready" ? Attaching before "deviceready" fires is still supported for events like resume, pause, offline, online, etc.. At least that's always being my impression for a long time
The only thing I would think it could be a potential confusion that would benefit to attached after "deviceready" is that if there is an "online" or "offline" event fire by webview [1], [2] and not plugin those handlers will fire but will not be from the network plugin. One thing I like thought about the PR is making index.js less verbose and simpler to follow +1 [1]: https://developer.mozilla.org/en-US/docs/Web/Events/offline [2]: https://developer.mozilla.org/en-US/docs/Web/Events/online On Mon, Feb 15, 2016 at 12:36 PM Parashuram N <panar...@microsoft.com> wrote: > While working on documentation about events for Cordova, we noticed that > in our Cordova starter template [1] seems to suggest that we bind events > like “offline” and “online” alongside the “deviceready” event. As I > understand, the “offline” and “online” events are something that the > NetworkInformation plugin provides, and thus should only be bound after > cordova-js has been initialized. > Here [2] is a change where we only bind “deviceready” first, and then > recommend binding all events when the handler for “deviceready” is called. > Do you folks think this is a good change ? Here [3] is the JIRA for it. > > > [1] Cordova Started template - > https://github.com/apache/cordova-app-hello-world/ > [2] Pull request with change to starter template - > https://github.com/apache/cordova-app-hello-world/pull/15/files > [3] JIRA for PR with change to starter template - > https://issues.apache.org/jira/browse/CB-10522 > > >
