Big plus one to Jesse's comment. I've felt like the template is too over complex for quite some time.
On Tue, Feb 16, 2016 at 3:21 PM, Ryan J. Salva <rsa...@microsoft.com> wrote: > Check out the default template we use in TACO-CLI. > > Index.js is a lot simpler and we adopted the new Cordova typeface. If folks > like this template, we could issue a PR for it. > > rjs > > > Ryan J. Salva | Principal PM Manager > Visual Studio Tools for Apache Cordova > rsa...@microsoft.com > 425 706 5270 office > 206 612 5079 mobile > > -----Original Message----- > From: Parashuram N [mailto:panar...@microsoft.com] > Sent: Tuesday, February 16, 2016 12:46 PM > To: dev@cordova.apache.org > Subject: RE: [DISCUSS] Update to starter template > > I do agree that our starter app needs to change. However, we encountered this > when we were looking at documenting, and our object of concern was the way > events are bound. My suggestion would be to simply fix the event binding so > that the docs are less confusing. > > We could then look at re-writing the starter-app itself. > > -----Original Message----- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Tuesday, February 16, 2016 12:28 PM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Update to starter template > > Personally, I think we should rewrite/simplify that template ALOT. > The app binding stuff is confusing to users, but not potentially any less > confusing with PR#15. The use of an object is the issue in my mind. > > Also, if this is the starting point for a new developer, they will soon > wonder why everything they add to the page is UPPERCASE, part of the css, but > potentially confusing. > > Ultimately, I think the whole starting point is over-organized with it's > multiple folders. PR#5 is closer to the goal I think, although I would still > leave js in an external file, and not directly in index.html and I would > leave quotes on html tag attributes. > > > > > > @purplecabbage > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cpanarasi%40microsoft.com%7ca55c7ca45ac24069c54708d337118610%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2bCP4GywoLaqppsEXaqZxo%2br%2baBb0%2b%2babaAImEmW4ZMg%3d > > On Tue, Feb 16, 2016 at 11:07 AM, Parashuram N <panar...@microsoft.com> > wrote: > >> Will do. >> >> -----Original Message----- >> From: Steven Gill [mailto:stevengil...@gmail.com] >> Sent: Tuesday, February 16, 2016 10:44 AM >> To: dev@cordova.apache.org >> Subject: Re: [DISCUSS] Update to starter template >> >> LGTM >> >> Could you also add the keyword 'cordova:template' to package.json? >> >> On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N <panar...@microsoft.com> >> wrote: >> >> > :) Sounds good >> > >> > Anyone else have any objections to the change ? >> > >> > -----Original Message----- >> > From: Carlos Santana [mailto:csantan...@gmail.com] >> > Sent: Monday, February 15, 2016 7:51 PM >> > To: dev@cordova.apache.org >> > Subject: Re: [DISCUSS] Update to starter template >> > >> > I'm always in favor of having simple answers and guidelines, and we >> > can take this as a good convention/practice >> > >> > "Always bind/attach after deviceready even and you will be in a >> > happy place" >> > >> > But between you and me you know that we can attach before, will >> > leave that little secret between us :-) >> > >> > >> > On Mon, Feb 15, 2016 at 10:44 PM Parashuram N >> > <panar...@microsoft.com> >> > wrote: >> > >> > > The reason to say that all events are fired after device ready is >> > > just to make it simpler. As you say, events by webviews are indeed >> > > fired before that, but I think it is safe to say that if we attach >> > > listeners after deviceready, we are guaranteed to have the plugins >> > > also initialized. This makes for a more consistent story. >> > > >> > > >> > > >> > > On 2/15/16, 7:25 PM, "Carlos Santana" <csantan...@gmail.com> wrote: >> > > >> > > >Why do you think that binding is required after "deviceready" ? >> > > > >> > > >Attaching before "deviceready" fires is still supported for >> > > >events like resume, pause, offline, online, etc.. At least that's >> > > >always being my impression for a long time >> > > > >> > > >The only thing I would think it could be a potential confusion >> > > >that would benefit to attached after "deviceready" is that if >> > > >there is an "online" or "offline" event fire by webview [1], [2] >> > > >and not plugin those handlers >> > > will >> > > >fire but will not be from the network plugin. >> > > > >> > > >One thing I like thought about the PR is making index.js less >> > > >verbose and simpler to follow +1 >> > > > >> > > >[1]: >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fd >> > > ev >> > > el >> > > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline&data=01%7 >> > > c0 >> > > 1% >> > > 7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72 >> > > f9 >> > > 88 >> > > bf86f141af91ab2d7cd011db47%7c1&sdata=8%2b4NzK8zAB%2ffqryeM%2fN9XYn >> > > mu >> > > lm >> > > bzlAeIogT9H1b4ic%3d >> > > >[2]: >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fd >> > > ev >> > > el >> > > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2fonline&data=01%7c >> > > 01 >> > > %7 >> > > cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f >> > > 98 >> > > 8b >> > > f86f141af91ab2d7cd011db47%7c1&sdata=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7 >> > > Cd >> > > IA >> > > XaRnZbqR4%3d >> > > > >> > > > >> > > >On Mon, Feb 15, 2016 at 12:36 PM Parashuram N >> > > ><panar...@microsoft.com> >> > > >wrote: >> > > > >> > > >> While working on documentation about events for Cordova, we >> > > >> noticed that in our Cordova starter template [1] seems to >> > > >> suggest that we bind events like “offline” and “online” >> > > >> alongside the >> “deviceready” >> > > >> event. As I understand, the “offline” and “online” events are >> > > >> something that the NetworkInformation plugin provides, and thus >> > > >> should only be bound after cordova-js has been initialized. >> > > >> Here [2] is a change where we only bind “deviceready” first, >> > > >> and then recommend binding all events when the handler for >> > > >> “deviceready” is >> > > called. >> > > >> Do you folks think this is a good change ? Here [3] is the JIRA >> > > >> for >> > it. >> > > >> >> > > >> >> > > >> [1] Cordova Started template - >> > > >> https://github.com/apache/cordova-app-hello-world/ >> > > >> [2] Pull request with change to starter template - >> > > >> https://github.com/apache/cordova-app-hello-world/pull/15/files >> > > >> [3] JIRA for PR with change to starter template - >> > > >> >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi >> > > ss >> > > ue >> > > s.apache.org%2fjira%2fbrowse%2fCB-10522&data=01%7c01%7cpanarasi%40 >> > > mi >> > > cr >> > > osoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91a >> > > b2 >> > > d7 >> > > cd011db47%7c1&sdata=66cC5xZm3Rh6xzxjqV48u%2bdrZSJZba1g%2f%2beFnwL7 >> > > aG >> > > k% >> > > 3d >> > > >> >> > > >> >> > > >> >> > > >> > > ------------------------------------------------------------------ >> > > -- >> > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> > > For additional commands, e-mail: dev-h...@cordova.apache.org >> > > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> -- =========================================================================== Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
