This is off topic, but Steve could you please consider including this PR into new cordova-common: https://github.com/apache/cordova-lib/pull/470/files, thanks
- Vladimir -----Original Message----- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Saturday, July 30, 2016 3:25 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Android 5.2.2 release android@5.2.2 and ios release are going to be postponed. Need to do a cordova-common release with the fix first. On Fri, Jul 29, 2016 at 5:24 PM, Steven Gill <stevengil...@gmail.com> wrote: > Sent a PR. Should get reviewed by ppl who worked closer on edit-config > to see if my changes will cause a problem. > https://github.com/apache/cordova-lib/pull/473 > > On Fri, Jul 29, 2016 at 3:31 PM, Steven Gill <stevengil...@gmail.com> > wrote: > >> Issue: >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissu >> es.apache.org%2fjira%2fbrowse%2fCB-11645&data=01%7c01%7cv-vlkoti%40mi >> crosoft.com%7c090e0bcb8c714cd86a5308d3b810073e%7c72f988bf86f141af91ab >> 2d7cd011db47%7c1&sdata=nM1luNQ01neqmRvd9nDxysK59KlKfqHk0OUsXDFyT2U%3d >> >> On Fri, Jul 29, 2016 at 12:03 PM, Steven Gill >> <stevengil...@gmail.com> >> wrote: >> >>> So a pretty big problem of this patch release is that it requires >>> cordova >= 6.3.0. I don't think we can release it as is. We can't >>> break compatibility for everyone using older versions of cordova >>> over a patch release and minor release (cordova-common) >>> >>> On Mon, Jul 25, 2016 at 1:05 PM, Simon MacDonald < >>> simon.macdon...@gmail.com> wrote: >>> >>>> I'd love to see a patch release out for Android and iOS. >>>> >>>> On Jul 25, 2016 15:45, "Jesse" <purplecabb...@gmail.com> wrote: >>>> >>>> > None that I see so far. >>>> > >>>> > We should merge this pr [1] and release docs as well, since this >>>> > is >>>> > platform+tools related. >>>> > There is a jira issue with many linked pr's also [2] so we should >>>> make sure >>>> > this all gets closed out together. >>>> > >>>> > [1] https://github.com/apache/cordova-docs/pull/614 >>>> > [2] >>>> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2f >>>> > issues.apache.org%2fjira%2fbrowse%2fCB-11023&data=01%7c01%7cv-vlk >>>> > oti%40microsoft.com%7c090e0bcb8c714cd86a5308d3b810073e%7c72f988bf >>>> > 86f141af91ab2d7cd011db47%7c1&sdata=EMYz2B4grhktgxYZ5uOfiFSgdnxAvo >>>> > NDMltge4Lj85g%3d >>>> > >>>> > >>>> > >>>> > @purplecabbage >>>> > risingj.com >>>> > >>>> > On Mon, Jul 25, 2016 at 10:56 AM, Steven Gill >>>> > <stevengil...@gmail.com >>>> > >>>> > wrote: >>>> > >>>> > > Need to do a patch release of cordova-android that contains the >>>> latest >>>> > > cordova-common release. This is needed to work with edit-config >>>> > > tag >>>> for >>>> > > plugin.xml. >>>> > > >>>> > > Bug: >>>> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f% >>>> > > 2fissues.apache.org%2fjira%2fbrowse%2fCB-11615&data=01%7c01%7cv >>>> > > -vlkoti%40microsoft.com%7c090e0bcb8c714cd86a5308d3b810073e%7c72 >>>> > > f988bf86f141af91ab2d7cd011db47%7c1&sdata=IyIsgQMxghii14Q2GQab%2 >>>> > > bfnT6F3VvoUZeQJbDnDwK1M%3d >>>> > > >>>> > > Any blockers? >>>> > > >>>> > > -Steve >>>> > > >>>> > >>>> >>> >>> >> >
