> On 6 Jul 2015, at 6:42 pm, jan i <j...@apache.org> wrote: > > On 6 July 2015 at 12:42, Peter Kelly <pmke...@apache.org> wrote: > >> Hi Ian, looks decent so far. Just a few comments: >> >> ODFLenses.h is missing from the CMakeLists.txt file. This won’t affect >> compilation at all, but it does mean that it will now show up in the file >> list in IDEs like Xcode and Visual Studio. >> >> I got a number of “control reaches end of non-void function” warnings, >> mostly in functions marked TBD, like ODFPut and ODFCreate. I’d recommend >> setting a “not implemented” error here using DFErrorFormat, and then >> returning 0. >> > +1, I always get suspicious when I get that warning. > > Should we move the code to trunk ? I suggest to do it.
Yes master is fine, given it’s for in-development stuff and we have a separate stable branch. — Dr Peter M. Kelly pmke...@apache.org PGP key: http://www.kellypmk.net/pgp-key <http://www.kellypmk.net/pgp-key> (fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966)
