> On 6 Jul 2015, at 8:04 pm, Ian C <i...@amham.net> wrote: > > Thanks for the feedback. > > Re warnings, I don't see any in the ODF code, I get a couple in minizip. > > Am I missing some compiler/make switches I wonder. > > My compiler is gcc version 4.9.2 20150212 (Red Hat 4.9.2-6) (GCC) > > If I'd seen the warnings I would have addressed them.
I’m using Xcode 6.4, which uses clang as its compiler: Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) Target: x86_64-apple-darwin14.4.0 Thread model: posix I’m fortunate enough to have OS X, Ubuntu, and Window 7 accessible to me (the latter two under VMs) and always test new commits on all three platforms before pushing, but I understand not everyone has such a setup - so don’t feel bad about missing warnings that don’t show up on your system. I’ll be happy to correct any problems I see as they arise if you like. Jan: Do you know if it would be possible for us to get buildbots set up for the three platforms? Here are the errors I get: DocFormats/filters/odf/src/ODF.c:30:19: Unused variable 'conv' DocFormats/filters/odf/src/ODF.c:54:1: Control reaches end of non-void function DocFormats/filters/odf/src/ODF.c:59:1: Control reaches end of non-void function DocFormats/filters/odf/src/formatting/ODFStyles.c DocFormats/filters/odf/src/formatting/ODFStyles.c:49:62: Data argument not used by format string DocFormats/filters/odf/src/formatting/ODFStyles.c:120:128: Data argument not used by format string DocFormats/filters/odf/src/formatting/ODFStyles.c:146:112: Data argument not used by format string DocFormats/filters/odf/src/formatting/ODFStyles.c:169:110: Data argument not used by format string DocFormats/filters/odf/src/text/ODFText.c DocFormats/filters/odf/src/text/ODFText.c:157:1: Control reaches end of non-void function DocFormats/filters/odf/src/text/gbg_test.c DocFormats/filters/odf/src/text/gbg_test.c:139:21: Unused variable 's' DocFormats/filters/odf/src/text/gbg_test.c:318:51: Format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'Tag' (aka 'unsigned int') DocFormats/filters/odf/src/text/gbg_test.c:334:28: Unused variable 'attrDecl' DocFormats/filters/odf/src/text/gbg_test.c:346:54: Format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'Tag' (aka 'unsigned int') — Dr Peter M. Kelly pmke...@apache.org PGP key: http://www.kellypmk.net/pgp-key <http://www.kellypmk.net/pgp-key> (fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966)
