Unfortunately I'll have to revert the commits. R13B03 and bellow don't allow for macros with same name but different arities - compilation fails. I guess we'll have to use import where needed.
On Mon, Sep 27, 2010 at 7:59 PM, Filipe David Manana <[email protected]> wrote: > On Mon, Sep 27, 2010 at 7:46 PM, Damien Katz <[email protected]> wrote: >> I wouldn't mind it being ?get(...) as required by a macro. Also, I think it >> could be an import statement in couch_db.hrl, so it's automatic for all >> including files. > > couch_util includes couch_db.hrl so we get a compile error. > >> >> -Damien >> >> >> On Sep 27, 2010, at 11:06 AM, Filipe David Manana wrote: >> >>> On Mon, Sep 27, 2010 at 7:04 PM, Adam Kocoloski <[email protected]> wrote: >>>> I don't like "get" because it clashes with the auto-imported erlang:get >>>> (for the process dictionary). >>>> >>>> Any reason to prefer a macro over an -import statement? >>> >>> Just to avoid doing the import everywhere and I still consider >>> get_value too long :P >>> >>>> >>>> Adam >>>> >>>> On Sep 27, 2010, at 1:47 PM, Filipe David Manana wrote: >>>> >>>>> Hi, >>>>> >>>>> I'm getting tired of typing couch_util:get_value(......). It also >>>>> consumes too much horizontal space. It's probably the most used >>>>> function from couch_util. >>>>> I'm thinking of adding a new macro in couch_db.hrl, like: >>>>> >>>>> -define(value(Key, List), couch_util:get_value(Key, List)). >>>>> >>>>> -define(value(Key, List, Default), couch_util:get_value(Key, List, >>>>> Default)). >>>>> >>>>> Or maybe naming the macro just "get". >>>>> >>>>> Anyone against it? >>>>> >>>>> >>>>> cheers >>>>> >>>>> -- >>>>> Filipe David Manana, >>>>> [email protected], [email protected] >>>>> >>>>> "Reasonable men adapt themselves to the world. >>>>> Unreasonable men adapt the world to themselves. >>>>> That's why all progress depends on unreasonable men." >>>> >>>> >>> >>> >>> >>> -- >>> Filipe David Manana, >>> [email protected], [email protected] >>> >>> "Reasonable men adapt themselves to the world. >>> Unreasonable men adapt the world to themselves. >>> That's why all progress depends on unreasonable men." >> >> > > > > -- > Filipe David Manana, > [email protected], [email protected] > > "Reasonable men adapt themselves to the world. > Unreasonable men adapt the world to themselves. > That's why all progress depends on unreasonable men." > -- Filipe David Manana, [email protected], [email protected] "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men."
