[
https://issues.apache.org/jira/browse/COUCHDB-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100453#comment-13100453
]
Volker Mische commented on COUCHDB-1270:
----------------------------------------
Great patch. Here's my review. I haven't spend too much time on
src/couch_mrview as I expect the code to basically the the same as in the
current implementation.
General:
The style for case indentation is not always CouchDB style. The first level
shouldn't be indented (I know that's a nit-pick :)
Configuration change:
The configuration variable for the indexes in the config was changed from
"view_index_dir" to "index_dir" with at mrviews sub-directory. Can we break
such things in 1.2?
src/couchdb/couch_compaction_daemon.erl still contains a reference to
view_index_dir.
API addition:
It should be documented that now you can compact views not only with
db/_compact/design-doc but also with db/design_doc/_compact, which actually
makes a lot more sense. The old one should be deprecated.
> Rewrite the view engine
> -----------------------
>
> Key: COUCHDB-1270
> URL: https://issues.apache.org/jira/browse/COUCHDB-1270
> Project: CouchDB
> Issue Type: Improvement
> Components: JavaScript View Server
> Reporter: Paul Joseph Davis
> Attachments: 0001-Minor-changes-for-new-indexing-engine.patch,
> 0002-Create-the-couch_index-application.patch,
> 0003-Create-the-couch_mrview-application.patch,
> 0004-Remove-the-old-view-engine.patch
>
>
> The view engine has been creaky and cluttered. As shown by GeoCouch, adding
> new indexers basically involves copying the entire view engine and hacking
> the parts that are different. In short, the opposite of good engineering.
> Over the last couple weeks I've refactored the view engine and reimplemented
> the map/reduce view engine. These changes are 100% internal and no external
> behavior has changed. Performance is just a tiny bit better than trunk. I did
> do some playing trying to improve view update times and there are some dances
> we could do, but for the time being I wanted to keep the same general
> architecture for updates so that the changes are minimal.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
