[ 
https://issues.apache.org/jira/browse/COUCHDB-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101666#comment-13101666
 ] 

Filipe Manana commented on COUCHDB-1270:
----------------------------------------

Paul just one question, looking at the 3rd patch:

diff --git a/share/www/script/test/view_compaction.js 
b/share/www/script/test/view_compaction.js
index 4c75184..ebf6fe1 100644
--- a/share/www/script/test/view_compaction.js
+++ b/share/www/script/test/view_compaction.js
@@ -87,7 +87,7 @@ couchTests.view_compaction = function(debug) {
   T(data_size_before_compact < disk_size_before_compact, "data size < file 
size");
 
   // compact view group
-  var xhr = CouchDB.request("POST", "/" + db.name + "/_compact" + "/foo");
+  var xhr = CouchDB.request("POST", "/" + db.name + "/_design/foo/_compact");
   T(JSON.parse(xhr.responseText).ok === true);
 
   resp = db.designInfo("_design/foo");
diff --git a/src/Makefile.am b/src/Makefile.am

Has the URI for view compaction changed or is it just an alternative?

> Rewrite the view engine
> -----------------------
>
>                 Key: COUCHDB-1270
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1270
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: JavaScript View Server
>            Reporter: Paul Joseph Davis
>         Attachments: 0001-Minor-changes-for-new-indexing-engine.patch, 
> 0002-Create-the-couch_index-application.patch, 
> 0003-Create-the-couch_mrview-application.patch, 
> 0004-Remove-the-old-view-engine.patch
>
>
> The view engine has been creaky and cluttered. As shown by GeoCouch, adding 
> new indexers basically involves copying the entire view engine and hacking 
> the parts that are different. In short, the opposite of good engineering.
> Over the last couple weeks I've refactored the view engine and reimplemented 
> the map/reduce view engine. These changes are 100% internal and no external 
> behavior has changed. Performance is just a tiny bit better than trunk. I did 
> do some playing trying to improve view update times and there are some dances 
> we could do, but for the time being I wanted to keep the same general 
> architecture for updates so that the changes are minimal.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to