Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/1#issuecomment-35157662
I think it'd be good to clean up the {From, Lang} vs. {From, Lang, DDoc,
DDocKey} mess. Lets add a record `#client{timestamp, lang, ddoc, ddockey}`
record and then update accordingly. I'd pull the code out of the handle_calls
for get_proc and create a new 'find_proc' function that takes the `#client{}`
record along with updating the new_proc calls.
I'd also like to see a bit better function organization. Something like,
find_proc, iter_procs, new_proc, make_proc, ret_proc, maybe_spawn_proc,
add_waiting_client, get_waiting_client. Currently reading things out of order
is a bit confusing.
Looks good other than that. Good idea on using the ordered_sets/timestamp
approach for queueing.
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
