Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/203#discussion_r11425783
  
    --- Diff: src/fauxton/app/addons/activetasks/views.js ---
    @@ -28,23 +28,105 @@ function (app, FauxtonAPI, activetasks) {
     
       Views.Events = _.extend(Events, Backbone.Events);
     
    +  Views.View = FauxtonAPI.View.extend({
    +    tagName: "table",
    +
    +    className: "table table-bordered table-striped active-tasks",
    +
    +    template: "addons/activetasks/templates/table",
    +
    +    events: {
    +      "click th": "sortByType"
    +    },
    +
    +    filter: "all",
    +
    +    initialize: function (options) {
    +      ActiveTasks.events.on("tasks:filter", this.filterAndRender, this);
    +      this.collection.bind("reset", _.bind(this.render, this));
    +    },
    +
    +    beforeRender: function () {
    +      this.filterAndRender(this.filter);
    +    },
    +
    +    filterAndRender: function (view) {
    +      var self = this;
    --- End diff --
    
    We have tried to stick to a convention of using `var that = this`. I used 
to use `self` too, but we got to choose a convention and `that` is more 
javascripty. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to