Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/203#discussion_r11425831
--- Diff: src/fauxton/app/addons/activetasks/views.js ---
@@ -28,23 +28,105 @@ function (app, FauxtonAPI, activetasks) {
Views.Events = _.extend(Events, Backbone.Events);
+ Views.View = FauxtonAPI.View.extend({
+ tagName: "table",
+
+ className: "table table-bordered table-striped active-tasks",
+
+ template: "addons/activetasks/templates/table",
+
+ events: {
+ "click th": "sortByType"
+ },
+
+ filter: "all",
+
+ initialize: function (options) {
+ ActiveTasks.events.on("tasks:filter", this.filterAndRender, this);
+ this.collection.bind("reset", _.bind(this.render, this));
+ },
+
+ beforeRender: function () {
+ this.filterAndRender(this.filter);
+ },
+
+ filterAndRender: function (view) {
+ var self = this;
+ this.filter = view;
+ this.removeView("#tasks_go_here");
--- End diff --
for css we use the convention of hyphens. So `#tasks_go_here` should be
`#tasks-go-here`. Also something we have recently decided on is to prefix andy
css id's or classes with `js-` if it is used in the javascript. So that id
should be `#js-tasks-go-here`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
