Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/221#issuecomment-43818540
  
    @kxepal I just added comments, thanks for your feedback!
    
    > Access to secondary indexes is broken.
    
    should be fixed with 741794b
    
    > is it possible to preserve selection for browser history navigation?
    
    The was saving the state in a sessionStorage in the first version, but it 
introduced bugs and I removed it. Maybe a thing for a second iteration, it's 
possible to add this later with the current code...
    
    > How about to show there the list of selected doc ids?"  
    
    I like the idea and I would use a real, fancy dialog for that and not an 
alert box, but this would be another feature with some more work. I really like 
the idea, but I want to ship this code as soon as possible: to avoid merge 
conflicts and that people can make use of the feature so I try to keep the 
scope of the ticket small. With a real div as box we could also add a scrollbar 
and stuff like this, so we wouldn't even have to limit it to 50 items.
    
    > undo button
    
    Same for the undo button, I like the idea, but a undo for already bulk 
deleted docs is not in the scope of this issue for me (if I understand the idea 
right?). Or do you mean the possibility to unselect all boxes with a button? - 
I could add one for unselecting all items very fast.
    
    > can I select document by click on it's row in addition to direct hit on 
checkbox?
    
    Added it! It was easy and implemented fast :) (077387e)
    
    > Also, on deletion "Showing" counter doesn't get updated until you change 
the page size. 
    
    Should be fixed now (4bdd860)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to