Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/221#issuecomment-43829194
Wow! You really handled all of these, even some wishes! (: I didn't expect
that you handle them all since I put them just to not forget about how it would
be possible to improve the bulk deletion - I had to noted that /:
About the changes: all cool! Everything works! \o/
Just two little moments:
1. in case of deletion failure (due to lack of permission or validation
function) Fauxton says: `Failed to destroy: foobarbaz`. May be use "deleted"
term instead of "destroy"? It's common and sounds more recoverable as deletion
is. Sorry, didn't have a chance to test this on first review because of other
bugs.
2. document selection by click on the row works, but not above and under
checkbox space:
On image above it showed: red box is the dead zone when click doesn't
selects the doc, green boxes are where it does. Since "red zone" is bigger than
green ones, it's really sweet spot for the click. Firefox 29 and Chromium 35,
all on linux.
>> is it possible to preserve selection for browser history navigation?
> The was saving the state in a sessionStorage in the first version, but it
introduced bugs and I removed it. Maybe a thing for a second iteration, it's
possible to add this later with the current code...
No problem. Actually, I was curious is it even possible. +1 for later.
>> How about to show there the list of selected doc ids?"
> I like the idea and I would use a real, fancy dialog for that and not an
alert box, but this would be another feature with some more work. I really like
the idea, but I want to ship this code as soon as possible: to avoid merge
conflicts and that people can make use of the feature so I try to keep the
scope of the ticket small. With a real div as box we could also add a scrollbar
and stuff like this, so we wouldn't even have to limit it to 50 items.
+1. This feature really requires some extra care and worth another PR.
>> undo button
>Same for the undo button, I like the idea, but a undo for already bulk
deleted docs is not in the scope of this issue for me (if I understand the idea
right?). Or do you mean the possibility to unselect all boxes with a button? -
I could add one for unselecting all items very fast.
No, it's about undoing deletion operation. Say, you'd selected some docs,
click on delete all button and in the next second figure out that you done
wrong things. The idea is the same as in gmail: undo deletion, undo sent,
allowing to undo any operation which causes the major changes in the next few
seconds before they'll really get applied. Not much critical, but useful
feature. Again, if do this right, I believe that will come in result as new
Fauxton module which covers a lot of other cases too (like undo config option
deletion and more).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
