GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/111
Added constants.js file to core
@garrensmith, @rkowalski could I get a bit of feedback on this ticket:
1. Is FauxtonAPI.constants the place for this? I think a constants file is
certainly needed & belongs in app/core, but perhaps it should just include it
as a dependency rather than adding it to FauxtonAPI? It would be less verbose
to use, e.g.
```javascript
define(["constants"], function(C) {
// C.MY_CONSTANT
});
```
instead of `FauxtonAPI.constants.MY_CONSTANT`.
Thoughts?
2. Uppercase for constants OK? (cribbed from Googleâs JS style guide).
By the way, for now I just added a single constant and updated a single
file to use it. From here on out Iâll start using it for future work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton
2400-constants-file-added
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit d4f2a9a89b7210703140da3ae06fac331f919ad0
Author: Benjamin Keen <[email protected]>
Date: 2014-10-23T19:51:06Z
Added constants.js file to core
Closes COUCHDB-2400
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
