Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69328401
I found two general points:
- I am no Flux-expert but reading examples and tutorials I always see the
dispatcher separated from the store (in a separate file). Why are we adding the
dispatcher as a property to the stores? To me it seems that this leads to the
fact the Store and Dispatcher are the same Object/Element.
- We currently just use chais `assert` in Fauxton tests, this PR mixes
`assert` and `expect` - I personally prefer assert but I am also happy if we
decide to switch to `expect` - but I think we should keep it consistent and
stick to one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
