Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22864950
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use this file except in compliance with the License. You may obtain a
copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+
+define([
+ 'app',
+ 'api',
+ 'addons/documents/resources',
+ 'addons/documents/actiontypes'
+],
+function (app, FauxtonAPI, Documents, ActionTypes) {
+ var ActionHelpers = {
+ createNewDesignDoc: function (id, database) {
+ var designDoc = {
+ _id: id,
+ views: {
+ }
+ };
+
+ return new Documents.Doc(designDoc, {database: database});
+ },
+
+ findDesignDoc: function (designDocs, designDocId) {
+ return designDocs.find(function (doc) {
+ return doc.id === designDocId;
+ }).dDocModel();
+
+ }
+ };
+
+ return {
+ //helpers are added here for use in testing actions
+ helpers: ActionHelpers,
--- End diff --
i have no good feeling when we start to mix production code with testcode.
i see that the only test that uses it is a spy which get's called, that
verifies that another function is called. suggestion: lets test the result, not
the steps in between that we just can access by mixing in testcode in our
production environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
