Github user seanbarclay commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/242#issuecomment-70980379
  
    Hey @robertkowalski - nice job. I'm super excited to see this plugged in. 
There's a few minor tweaks needed here:
    1) The padding between the select icon and copy should be 8px. It currently 
has none. 
    2) Make sure the padding on the select button group and the other select 
options have a padding that equals 20px on left and right. It's currently 17px 
(5px + 12px). Check out the screen shot of what spacing should look like when 
tweaked: 
https://www.dropbox.com/s/8j83rnqyjfrctqt/Screenshot%202015-01-21%2023.06.51.png?dl=0
    3) Font-size for icons should be 20px
    4) cancel button does not require a vertical rule line on the right
    5) add a quick (250 ms) fade in/out transition for menus.  You could also 
have the .alternative-header slide in from left to right and fade in. If you do 
the latter, add a background-color to the select button.
    
    Thanks!
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to