Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/242#discussion_r23686237
  
    --- Diff: app/addons/documents/header/header.react.jsx ---
    @@ -0,0 +1,245 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may 
not
    +// use this file except in compliance with the License. You may obtain a 
copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, 
WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations 
under
    +// the License.
    +
    +define([
    +  'app',
    +  'api',
    +  'react',
    +  'addons/documents/header/header.stores',
    +  'addons/documents/header/header.actions'
    +],
    +
    +function (app, FauxtonAPI, React, Stores, Actions) {
    +  var ReactCSSTransitionGroup = React.addons.CSSTransitionGroup;
    +  var headerBarStore = Stores.headerBarStore;
    +  var bulkDocumentHeaderStore = Stores.bulkDocumentHeaderStore;
    +
    +  // this will be a global component
    +  var ToggleHeaderButton = React.createClass({
    +    render: function () {
    +      var iconClasses = 'icon ' + this.props.fonticon + ' ' + 
this.props.innerClasses,
    +          containerClasses = 'button ' + this.props.containerClasses;
    +
    +      if (this.props.setEnabledClass) {
    +        containerClasses = containerClasses + ' 
js-headerbar-togglebutton-selected';
    +      }
    +
    +      return (
    +        <button
    +          title={this.props.title}
    +          disabled={this.props.disabled}
    +          onClick={this.props.toggleCallback}
    +          className={containerClasses}
    +          >
    +          <i className={iconClasses}></i><span>{this.props.text}</span>
    +        </button>
    +      );
    +    }
    +  });
    +
    +  var BulkDocumentHeaderController = React.createClass({
    +    getStoreState: function () {
    +      return {
    +        areDocumentsCollapsed: bulkDocumentHeaderStore.getCollapsedState(),
    +        isDeselectPossible: 
bulkDocumentHeaderStore.getIsDeselectPossible(),
    +        isSelectAllPossible: 
bulkDocumentHeaderStore.getIsSelectAllPossible()
    +      };
    +    },
    +
    +    getInitialState: function () {
    +      return this.getStoreState();
    +    },
    +
    +    componentDidMount: function () {
    +      bulkDocumentHeaderStore.on('change', this.onChange, this);
    +    },
    +
    +    componentWillUnmount: function() {
    +      bulkDocumentHeaderStore.off('change', this.onChange);
    +    },
    +
    +    onChange: function () {
    +      this.setState(this.getStoreState());
    +    },
    +
    +    render: function () {
    +      var baseClass = 'header-control-box header-control-square ',
    +          isDeselectPossible = this.state.isDeselectPossible,
    +          isSelectAllPossible = this.state.isSelectAllPossible,
    +          areDocumentsCollapsed = this.state.areDocumentsCollapsed;
    +
    +      return (
    +        <div className='alternative-header'>
    +          <ToggleHeaderButton
    +            fonticon={'fonticon-select-all'}
    +            toggleCallback={this.selectAllDocuments}
    +            innerClasses={''}
    +            containerClasses={baseClass + 'control-select-all'}
    +            text={''}
    +            setEnabledClass={!isSelectAllPossible}
    +            disabled={!isSelectAllPossible}
    +            title={'Select all Documents'} />
    +
    +          <ToggleHeaderButton
    +            fonticon={'fonticon-deselect-all'}
    +            toggleCallback={this.deSelectAllDocuments}
    +            innerClasses={''}
    +            containerClasses={baseClass + 'control-de-select-all'}
    +            text={''}
    +            setEnabledClass={!isDeselectPossible}
    +            disabled={!isDeselectPossible}
    +            title={'Deselect all Documents'} />
    +
    +          <ToggleHeaderButton
    +            fonticon={'fonticon-collapse'}
    +            toggleCallback={this.toggleCollapseDocuments}
    +            innerClasses={''}
    +            containerClasses={baseClass + 'control-collapse'}
    +            text={''}
    +            setEnabledClass={areDocumentsCollapsed}
    +            disabled={areDocumentsCollapsed}
    +            title={'Collapse all'} />
    +
    +          <ToggleHeaderButton
    +            fonticon={'fonticon-expand'}
    +            toggleCallback={this.toggleCollapseDocuments}
    +            innerClasses={''}
    +            containerClasses={baseClass + 'control-expand'}
    +            text={''}
    +            setEnabledClass={!areDocumentsCollapsed}
    +            disabled={!areDocumentsCollapsed}
    +            title={'Expand all'} />
    +
    +          <ToggleHeaderButton
    +            fonticon={'fonticon-trash'}
    +            toggleCallback={this.deleteSelected}
    +            innerClasses={''}
    +            containerClasses={baseClass + 'control-delete'}
    +            text={''}
    +            title={'Delete selected'} />
    +
    +          <ToggleHeaderButton
    +            fonticon={''}
    +            toggleCallback={this.cancelView}
    +            innerClasses={''}
    +            containerClasses={baseClass + 'control-cancel'}
    +            text={'Cancel'}
    +            title={'Switch to other view'} />
    +        </div>
    +      );
    +    },
    +
    +    toggleCollapseDocuments: function () {
    +      Actions.toggleCollapseDocuments();
    +    },
    +
    +    selectAllDocuments: function () {
    +      Actions.toggleSelectAllDocuments(false);
    +    },
    +
    +    deSelectAllDocuments: function () {
    +      Actions.toggleSelectAllDocuments(true);
    +    },
    +
    +    cancelView: function () {
    +      Actions.toggleHeaderControls();
    +    },
    +
    +    deleteSelected: function () {
    +      Actions.deleteSelected();
    +    }
    +  });
    +
    +  var HeaderBarController = React.createClass({
    +    getStoreState: function () {
    +      return {
    +        isToggled: headerBarStore.getStatus(),
    --- End diff --
    
    Pretty minor thing. But `getStatus` doesn't mean much. Maybe make it 
`getToggleStatus`. That explains it more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to