Thank you for the review :) > On 4. Aug 2020, at 12:25, Bessenyei Balázs Donát <bes...@apache.org> wrote: > > Hey Jan, > > I've skimmed through the PR and the RFC and it looks good to me on a first > read! > I have two questions (requests, maybe) though: > - do you think adding some "system-level" (elixir, I guess) tests > would be valuable so that a more formalized specification (and > verification) of the behavior is available? (They certainly help me > understand functionality a lot.)
The Erlang tests are already exclusively using the HTTP API. I don’t plan to rewrite those to Elixir, but documentation on how to use this will be written before this is merged. > - what do you think about making this feature toggleable via an ini option? I could be persuaded to provide a default toggle like we have for `q` as an ini option, but I want to make sure people know this is opt-in behaviour, so I’m on the fence on allowing this to be the default on database creation. > Also, I've noticed there are a couple of TODO comments in the code. > Are you planning to remove them before merging? Absolutely :) Best Jan — > Anyway, I'm (non-binding) +1 on the change! > > > Thank you, > > Donat > > On Mon, 3 Aug 2020 at 17:29, Jan Lehnardt <j...@apache.org> wrote: >> >> *bump* Hey all, it’d be great to get at least some cursory feedback on this. >> >> Best >> Jan >> — >> >>> On 26. Jul 2020, at 20:28, Jan Lehnardt <j...@apache.org> wrote: >>> >>> Hey all, >>> >>> I’m happy to present the first PR worth sharing for introducing >>> per-doc-access control to the 3.x codebase. >>> >>> https://github.com/apache/couchdb/pull/3038 >>> >>> There are few odds and ends left to do, but this is in good enough shape to >>> get wider review on approach and implementation so far. >>> >>> My hope would be to include this in a future 3.2.0 release before embarking >>> on reimplementing this for 4.x, which should be considerably simpler. >>> >>> The PR and linked resources have most of the information relevant to this. >>> >>> Please review, test and critique heavily, and let me know any questions you >>> might have. >>> >>> This concludes a couple of weeks worth of effort spread across multiple >>> years. It all started with the developer summit in Boston and Adam’s >>> initial presentation of this design. I hope this makes it justice. >>> >>> Best >>> Jan >>> — >>> Professional Support for Apache CouchDB: >>> https://neighbourhood.ie/couchdb-support/ >>> >>
