I think I'm not qualified enough to write down a technical commentary, so the only thing I can do is congrat with Jan :-D
Alessio Il ven 21 ago 2020, 20:08 Joan Touzet <woh...@apache.org> ha scritto: > Comments, in no particular order: > > * I like that it's opt-in on a per-database level to create and maintain > the additional indexes. > > * I like that this is an MVP for the feature, one that will get more > advanced over time. > > * I guess we are putting off using maps (vs. records) until 4.x at the > earlier? > > * There's a whole lot of feedback on the RFC from the IBM core team that > needs to get addressed before that can be merged. Most of it is > structural, such as Garren's comments, but there are some questions > from Mike Rhodes to which I haven't seen Jan reply yet. I don't know > if the PR addresses those or not. > > * Obviously Jan needs help on point 9, which I'll start investigating > later today (after mid-day errands) > > * If this is intended to replace db-per-user, we should immediately > file the deprecation notice on that and prepare to remove it entirely > in 4.x. > > Great to see this move forward! > > -Joan "goin' to the bank like an adult" Touzet > > On 21/08/2020 08:20, Jan Lehnardt wrote: > > Hi all, I‘d like to once again solicit feedback from the core team about > my PR for per doc access control. > > > > I know we all have a lot to do, but it’d be great to get some pointers > on this, so I can gauge how much work it‘ll be to take over the finish line. > > > > If it helps any, I‘d be happy to set up a video call to walk folks > through the main parts. > > > > I understand that a lot of Cloudant folks are focused on 4.x, but when > we last talked, we deemed this feature important enough for 3.x, so I built > that first. The experience from building this suggests to me that’s 4.x > port should be fairly straightforward, and that that port should even make > it easy to add the much desired addition of group sharing. > > > > I’m equally happy to take silence as approval, in which case all I ask > for is a thumbs up, at which point, I‘ll plow through the remaining todos > and get this out asap. > > > > Best > > Jan > > — > > > >> On 3. Aug 2020, at 17:29, Jan Lehnardt <j...@apache.org> wrote: > >> > >> *bump* Hey all, it’d be great to get at least some cursory feedback on > this. > >> > >> Best > >> Jan > >> — > >> > >>>>> On 26. Jul 2020, at 20:28, Jan Lehnardt <j...@apache.org> wrote: > >>> Hey all, > >>> I’m happy to present the first PR worth sharing for introducing > per-doc-access control to the 3.x codebase. > >>> https://github.com/apache/couchdb/pull/3038 > >>> There are few odds and ends left to do, but this is in good enough > shape to get wider review on approach and implementation so far. > >>> My hope would be to include this in a future 3.2.0 release before > embarking on reimplementing this for 4.x, which should be considerably > simpler. > >>> The PR and linked resources have most of the information relevant to > this. > >>> Please review, test and critique heavily, and let me know any > questions you might have. > >>> This concludes a couple of weeks worth of effort spread across > multiple years. It all started with the developer summit in Boston and > Adam’s initial presentation of this design. I hope this makes it justice. > >>> Best > >>> Jan > >>> — > >>> Professional Support for Apache CouchDB: > >>> https://neighbourhood.ie/couchdb-support/ > > >
