Github user animeshtrivedi commented on a diff in the pull request:
https://github.com/apache/incubator-crail/pull/16#discussion_r180313400
--- Diff:
storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/NvmfStorageConstants.java
---
@@ -89,31 +76,31 @@ public static void updateConstants(CrailConfiguration
conf) throws UnknownHostEx
arg = get(conf, NQN_KEY);
if (arg != null) {
- NQN = arg;
+ NQN = new NvmeQualifiedName(arg);
}
arg = get(conf, ALLOCATION_SIZE_KEY);
if (arg != null) {
ALLOCATION_SIZE = Long.parseLong(arg);
}
- arg = get(conf, SERVER_MEMPOOL_KEY);
+ arg = get(conf, QUEUE_SIZE_KEY);
if (arg != null) {
- SERVER_MEMPOOL = Long.parseLong(arg);
+ QUEUE_SIZE = Integer.parseInt(arg);
}
- arg = get(conf, CLIENT_MEMPOOL_KEY);
+ arg = get(conf, STAGING_CACHE_SIZE_KEY);
if (arg != null) {
- CLIENT_MEMPOOL = Long.parseLong(arg);
+ STAGING_CACHE_SIZE = Integer.parseInt(arg);
}
}
- public static void verify() throws IOException {
- if (NAMESPACE <= 0){
- throw new IOException("Namespace must be > 0");
- }
+ public static void verify() {
if (ALLOCATION_SIZE % CrailConstants.BLOCK_SIZE != 0){
- throw new IOException("allocationsize must be multiple
of crail.blocksize");
+ throw new IllegalArgumentException("allocationsize must
be multiple of crail.blocksize");
--- End diff --
Usually I would recommend to print as much useful information possible in
exceptions. Can we print what was the crail.blocksize and allocation size that
we got here?
---
