[GitHub] incubator-crail pull request #16: New NVMf storage based on jNVMf library

[PepperJo]

Github user PepperJo commented on a diff in the pull request:

    https://github.com/apache/incubator-crail/pull/16#discussion_r180337304
  
    --- Diff: 
storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/NvmfStorageServer.java 
---
    @@ -86,15 +100,15 @@ public void run() {
        @Override
        public StorageResource allocateResource() throws Exception {
                StorageResource resource = null;
    -           
    +
                if (alignedSize > 0){
                        LOG.info("new block, length " + 
NvmfStorageConstants.ALLOCATION_SIZE);
    -                   LOG.debug("block stag 0, offset " + offset + ", length 
" + NvmfStorageConstants.ALLOCATION_SIZE);
    +                   LOG.debug("block stag 0, address " + address + ", 
length " + NvmfStorageConstants.ALLOCATION_SIZE);
                        alignedSize -= NvmfStorageConstants.ALLOCATION_SIZE;
    -                   resource = StorageResource.createResource(offset, 
(int)NvmfStorageConstants.ALLOCATION_SIZE, 0);
    -                   offset += NvmfStorageConstants.ALLOCATION_SIZE;
    +                   resource = StorageResource.createResource(address, 
(int)NvmfStorageConstants.ALLOCATION_SIZE, 0);
    --- End diff --
    
    Good point. Not sure why I made them long in the first place.

Advertising

---