+1 (binding) Downloaded, checked signatures and checksums. Checked LICENSE, NOTICE, README.md, KEYS, headers, ran RAT. Built using JDK 8 on MacOS.
One thing: The key is not linked into a web of trust[1]. It doesn’t have to happen before the release, and won’t alter the artifacts for this release, but let’s do it soon. Another minor thing: KEYS[2] mentions Gearpump at one point. I think you meant Crail! (The gpg “HOWTO” at the top of KEYS is most welcome. Thanks for that!) Julian [1] https://www.apache.org/dev/release-signing.html#link-into-wot <https://www.apache.org/dev/release-signing.html#link-into-wot> [2] https://dist.apache.org/repos/dist/release/incubator/crail/KEYS <https://dist.apache.org/repos/dist/release/incubator/crail/KEYS> > On Apr 23, 2018, at 4:40 AM, Jonas Pfefferle <peppe...@japf.ch> wrote: > > Hi all, > > I fixed all the comments from rc1 and created rc2: > > * Add all three source download options in README (@Julian requirements were > already there) > * Fix NOTICE file to include actual year for Apache Software Foundation > * Fix signatures > * Created KEYS file > https://dist.apache.org/repos/dist/release/incubator/crail/KEYS > > Thanks to everyone who has contributed to this release. > You can read the release notes here: > https://github.com/apache/incubator-crail/blob/master/HISTORY.md > > The commit to be voted upon: > > > https://git1-us-west.apache.org/repos/asf?p=incubator-crail.git;a=commit;h=749f44206943fcaef0841ed89411013c2dc11d64 > > Its hash is 749f44206943fcaef0841ed89411013c2dc11d64. > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/incubator/crail/1.0-rc2/ > > The hashes of the artifacts are as follows: > source.tar.gz.sha256 > 6900341d8d8347be71107fe8c766358b587d96a3e505cd501f6d0d8690a3f3c7 > source.zip.sha256 > 51c2b11658e70ef0b7a80c427d88ee1a928fae8499f3910fe9bcc89a6fcfa5e3 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/pepperjo.asc > > Please vote on releasing this package as Apache Crail 1.0 incubating. > > The vote is open for the next 72 hours and passes if a majority of > at least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Crail 1.0 incubating > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > Here is my vote: > > +1 > > Jonas > > >
