Claudenw commented on code in PR #160:
URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377179769
##########
apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java:
##########
@@ -109,6 +118,7 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
return;
}
ReportConfiguration config = getConfiguration();
+ config.setScanHiddenDirectories(scanHiddenDirectories);
Review Comment:
This line should be in the getConfiguration() method.
There is a ticket to change the way the tests are executed against UIs and
it will be necessary for the getConfiguration() to handle all configuration
changes that are driven by UI options..
##########
apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java:
##########
Review Comment:
I think that the DirectoryWalker should accept a second FilenameFIlter
rather than a boolean to limit the files, similar to the way the files are
filtered. This will give us more control over what files to read -- I see this
as being necessary for some of the harmonization work that is coming.
Specifically reading specific hidden directories.
This change means that the configuration needs a pair of methods to set and
get the input directory filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
