jbonofre commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1403497746
########## apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java: ########## Review Comment: I experimented using `IOFileFilter` (leveraging `HiddenFileFilter`, `FalseFileFilter`, etc). Adding `addDirectoryFilter()` to `ReportConfiguration` is OK (and using `IOFileFIlter#and()` to add multiple filters. At code level, it works fine, but I have a concern about the "usage", especially on the CLI and Maven. I think for the CLI, we should keep the proposed option (`--scan-hidden-directories` for CLI for instance) to simplify the use. Thoughts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
