ottlinger commented on code in PR #397: URL: https://github.com/apache/creadur-rat/pull/397#discussion_r1861956810
########## apache-rat-core/src/main/java/org/apache/rat/document/DocumentNameMatcher.java: ########## @@ -20,17 +20,206 @@ import java.io.File; import java.io.FileFilter; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.List; +import java.util.function.Predicate; -@FunctionalInterface -public interface DocumentNameMatcher { - boolean matches(DocumentName documentName); +import org.apache.rat.config.exclusion.plexus.MatchPattern; +import org.apache.rat.config.exclusion.plexus.MatchPatterns; + +import static java.lang.String.format; + +/** + * Matches document names. + */ +public final class DocumentNameMatcher { + + /** The environment variable to set to enable tracing for the PatternMatcher execution */ + public static final String ENV_VAR = DocumentNameMatcher.class.getName(); Review Comment: Shouldn't there be a reference to this ENV_VAR if it is used to indicate or change something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org