Claudenw commented on code in PR #397:
URL: https://github.com/apache/creadur-rat/pull/397#discussion_r1862000269


##########
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:
##########
@@ -159,6 +169,55 @@ public ReportConfiguration() {
         dryRun = false;
         exclusionProcessor = new ExclusionProcessor();
         claimValidator = new ClaimValidator();
+        sources = new ArrayList<>();
+        reportables = new ArrayList<>();
+    }
+
+    /**
+     * Adds a file as a source of files to scan.
+     * The file must be a text file that lists files to be included.
+     * File within the file must be in linux format with a
+     * "/" file separator.
+     * @param file the file to process.
+     */
+    public void addSource(final File file) {

Review Comment:
   The parameter may have backslashes if it is on a Windows box.  But the 
contents for the file identified by the parameter should use "/" as the 
separator.  Failure to do so may or may not work depending on a lot of other 
conditions.   I don't think we can/should check for the presence of the 
backslash as it might be a valid character in a file name.  OK that is a 
stretch, but I think we should leave it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to