Claudenw commented on code in PR #708:
URL: https://github.com/apache/creadur-rat/pull/708#discussion_r3991066975
##########
apache-rat-core/src/main/java/org/apache/rat/ui/UIOptionCollection.java:
##########
@@ -209,59 +249,51 @@ protected Builder(final BiFunction<UIOptionCollection<T>,
Option, T> mapper) {
}
/**
- * Build the UIOptionCollection.
- * @return the UIOptionCollection.
- */
- public UIOptionCollection<T> build() {
- return new UIOptionCollection<>(this);
- }
-
- /**
- * Returns this cast to {@code <S>} class.
- * @return this as {@code <S>} class.
+ * Returns this cast to {@code <B>} class.
+ * @return this as {@code <B>} class.
*/
- protected final S self() {
- return (S) this;
+ protected final B self() {
+ return (B) this;
}
/**
- * Add a UI option to the collection.
- * @param uiOption the UI Option to add.
+ * Add an Option to the collection as a UIOption.
+ * @param option the Option to add.
* @return this
*/
- public S uiOption(final Option uiOption) {
- uiOptions.add(uiOption);
+ public B uiOption(final Option option) {
+ uiOptions.add(option);
return self();
}
/**
- * Add a UI options to the collection.
- * @param uiOption the UIOptions ({@code <T>} objects) to add.
+ * Add multiple Option instances to the collection as UIOptions.
+ * @param options the Option instances to add.
* @return this
*/
- public S uiOptions(final Option... uiOption) {
- uiOptions.addAll(Arrays.asList(uiOption));
+ public B uiOptions(final Option... options) {
Review Comment:
I believe so. When building a UI there are options that are specific to the
UI (like the Maven option that excluded common patterns) that the UI will add.
I think there are cases where there will be more than one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
