Claudenw commented on code in PR #708:
URL: https://github.com/apache/creadur-rat/pull/708#discussion_r3991139124
##########
apache-rat-core/src/main/java/org/apache/rat/OptionCollection.java:
##########
@@ -188,25 +189,38 @@ public static synchronized ReportConfiguration
parseCommands(final File workingD
* @see #parseCommands(File, String[], Consumer, boolean)
*/
public static ReportConfiguration createConfiguration(final
ArgumentContext argumentContext) {
- argumentContext.processArgs(CLIOptionCollection.INSTANCE);
- final ReportConfiguration configuration =
argumentContext.getConfiguration();
- final CommandLine commandLine = argumentContext.getCommandLine();
- Optional<Option> dirOpt =
CLIOptionCollection.INSTANCE.getSelected(Arg.DIR);
- if (dirOpt.isPresent()) {
- try {
-
configuration.addSource(getReportable(commandLine.getParsedOptionValue(
- dirOpt.get()), configuration));
- } catch (ParseException e) {
- throw new ConfigurationException("Unable to set parse " +
dirOpt.get(), e);
+ try {
+ argumentContext.processArgs(baseOptionCollection);
+ final ReportConfiguration configuration =
argumentContext.getConfiguration();
+ final CommandLine commandLine = argumentContext.getCommandLine();
+ Optional<Option> dirOpt =
baseOptionCollection.getSelected(Arg.DIR);
Review Comment:
Fixed but will probalby change when the UI builds are extracted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
