[ 
https://issues.apache.org/jira/browse/CRUNCH-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679358#comment-13679358
 ] 

Gabriel Reid commented on CRUNCH-216:
-------------------------------------

Obviously this is somewhat dangerous, as it's not changing the API, but 
changing the behavior. On the other hand, the MapsideJoinStrategy is a new 
class, and the MapsideJoin class (with the same functionality) is gone now, so 
maybe it's not so bad just to change it now while we're changing the whole join 
interfaces in general.
                
> Transpose arguments in MapsideJoinStrategy.join
> -----------------------------------------------
>
>                 Key: CRUNCH-216
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-216
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Gabriel Reid
>
> The MapsideJoinStrategy currently specifies that the smaller table in the 
> join (i.e. the table to be replicated and loaded in memory) should be on the 
> right-hand side of the join.
> This is the opposite of what is done in all other join strategies, making it 
> impossible to just switch out another join strategy for a 
> MapsideJoinStrategy. The MapsideJoinStrategy could be brought in line with 
> the other JoinStrategies to expect the smaller of two tables to be provided 
> as the left-side table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to