[ 
https://issues.apache.org/jira/browse/CRUNCH-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902577#comment-13902577
 ] 

Josh Wills commented on CRUNCH-216:
-----------------------------------

And I'm +1 for just deprecating the constructor and leaving off the legacy 
factory methods.

> Transpose arguments in MapsideJoinStrategy.join
> -----------------------------------------------
>
>                 Key: CRUNCH-216
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-216
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Gabriel Reid
>         Attachments: CRUNCH-216.patch
>
>
> The MapsideJoinStrategy currently specifies that the smaller table in the 
> join (i.e. the table to be replicated and loaded in memory) should be on the 
> right-hand side of the join.
> This is the opposite of what is done in all other join strategies, making it 
> impossible to just switch out another join strategy for a 
> MapsideJoinStrategy. The MapsideJoinStrategy could be brought in line with 
> the other JoinStrategies to expect the smaller of two tables to be provided 
> as the left-side table.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to