[
https://issues.apache.org/jira/browse/CRUNCH-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713882#comment-13713882
]
Gabriel Reid commented on CRUNCH-240:
-------------------------------------
Now you've really piqued my curiosity :-)
I'm guessing you probably can't share any details on the spatial join stuff,
but am I right in assuming that the general idea behind a custom JoinFn is
getting all potential to-join values together in the JoinFn, and then doing
some kind of fuzzy joining within the JoinFn once you've got them there?
I'm wondering if there's some way we can make things like that a bit more
friendly to develop against -- I think the current JoinFn is pretty
tightly-bound to the internals of the DefaultJoinStrategy, but it could be cool
if we could make a more generic interface for using that kind of idea with
other join strategies too (if that is indeed the idea you're using).
> Make DefaultJoinStrategy.join(PTable, PTable, JoinFn) public
> ------------------------------------------------------------
>
> Key: CRUNCH-240
> URL: https://issues.apache.org/jira/browse/CRUNCH-240
> Project: Crunch
> Issue Type: Bug
> Reporter: Josh Wills
> Fix For: 0.7.0
>
> Attachments: CRUNCH-240.patch
>
>
> The API refactoring made the default join implementation that allowed clients
> to specify custom JoinFn implementations package protected instead of public.
> This patch makes it public again so that existing custom JoinFn impls will
> still work on Crunch 0.7.0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
