Hi,
The official Jenkins job (referenced in the pom.xml) is:
https://builds.apache.org/job/ctakes-trunk/. As one may notice, the status
is Unstable. I was working on the cTAKES-trunk-Java-1.8 Jenkins job [1] to
try to fix the issues there. As such the tests failed can be found here [2].
So trying to fix one by one, I discovered that for
ctakes-ytex:ConceptDaoTest.java:testCreateConceptGraph:
There is the construction:
metadata.getPatientIdentifier()
(where metadata:org.apache.ctakes.typesystem.type.structured.Metadata).
Researching where this comes (because it seems it is a new issue), I
realized that is related to:
ctakes-type-system/target/generated-sources/jcasgen/org/apache/ctakes/typesystem/type/structured/Metadata.java
:75: public String getPatientIdentifier() {
more:
https://github.com/apache/ctakes/commit/bcdc25420eede623a0889b1db26e1307a2b193bf
(10 Oct 2017)
I thought that it will be a quick fix just replacing:
metadata.getPatientIdentifier()
with
String.format("%d", metadata.getPatientID());
Any feedback?
Alex
[1] -
https://builds.apache.org/view/C/view/Apache%20cTAKES/job/cTAKES-trunk-Java-1.8/
[2] -
https://builds.apache.org/view/C/view/Apache%20cTAKES/job/cTAKES-trunk-Java-1.8/25/testReport/
On Nov 13, 2017 10:41, "Finan, Sean" <sean.fi...@childrens.harvard.edu>
wrote:
> Thanks Gandhi!
>
> -----Original Message-----
> From: Gandhi Rajan Natarajan [mailto:gandhi.natara...@arisglobal.com]
> Sent: Monday, November 13, 2017 10:40 AM
> To: dev@ctakes.apache.org
> Subject: RE: Disable yTEX and Regression tests on Jenkins [EXTERNAL]
>
> Hi All,
>
> We had a look at ctakes-Ytex module's failing test cases and looks like it
> will not have an impact once we upgrade Spring 4x in cTAKES.
>
> We will have a run through at other modules and check the failing test
> cases if any.
>
> Regards,
> Gandhi
>
>
> -----Original Message-----
> From: Sandeep Byatha Gururaja rao [mailto:sandeep...@arisglobal.com]
> Sent: Monday, November 13, 2017 6:50 PM
> To: dev@ctakes.apache.org
> Subject: RE: Disable yTEX and Regression tests on Jenkins [EXTERNAL]
>
> Hi Sean,
>
> Myself and Gandhi will work on this and try to fix the issues.
>
> Regards,
> Sandeep
>
> ------------------------------------
>
> Hi Gandhi,
>
> Many thanks for volunteering. I am slammed with work right now, but if
> anybody else can also help out ...
>
> Sean
>
> -----Original Message-----
> From: Gandhi Rajan Natarajan [mailto:gandhi.natara...@arisglobal.com]
> Sent: Thursday, November 09, 2017 12:43 AM
> To: dev@ctakes.apache.org
> Subject: RE: Disable yTEX and Regression tests on Jenkins [EXTERNAL]
>
> Hi Sean,
>
> I can take it up if someone is willing to guide me on this.
>
> Regards,
> Gandhi
>
>
> -----Original Message-----
> From: Finan, Sean [mailto:sean.fi...@childrens.harvard.edu]
> Sent: Wednesday, November 08, 2017 9:45 PM
> To: dev@ctakes.apache.org
> Subject: Disable yTEX and Regression tests on Jenkins
>
> Hi all,
>
> The Jenkins builds have been failing for about a month now because of
> internal Jenkins changes and 'unit' tests in the ctakes-Regression and
> ctakes-yTEX modules. This is holding up the build for all of our primary
> clinical-pipeline modules.
>
> If anybody can take a look at the problems and fix them please respond to
> this email. Otherwise I would like to create a jira issue and disable them
> until somebody does have the time to take care of them. If you have a good
> reason for these tests not being disabled (e.g. we might forget to fix
> them) please state a case. I do not intend to act unilaterally on this
> issue.
>
> Please respond by midnight Friday, November 10.
>
> Thank you,
>
> Sean
> This email and any files transmitted with it are confidential and intended
> solely for the use of the individual or entity to whom they are addressed.
> If you are not the named addressee you should not disseminate, distribute
> or copy this e-mail. Please notify the sender or system manager by email
> immediately if you have received this e-mail by mistake and delete this
> e-mail from your system. If you are not the intended recipient you are
> notified that disclosing, copying, distributing or taking any action in
> reliance on the contents of this information is strictly prohibited and
> against the law.
>
> This email and any files transmitted with it are confidential and intended
> solely for the use of the individual or entity to whom they are addressed.
> If you are not the named addressee you should not disseminate, distribute
> or copy this e-mail. Please notify the sender or system manager by email
> immediately if you have received this e-mail by mistake and delete this
> e-mail from your system. If you are not the intended recipient you are
> notified that disclosing, copying, distributing or taking any action in
> reliance on the contents of this information is strictly prohibited and
> against the law.
> This email and any files transmitted with it are confidential and intended
> solely for the use of the individual or entity to whom they are addressed.
> If you are not the named addressee you should not disseminate, distribute
> or copy this e-mail. Please notify the sender or system manager by email
> immediately if you have received this e-mail by mistake and delete this
> e-mail from your system. If you are not the intended recipient you are
> notified that disclosing, copying, distributing or taking any action in
> reliance on the contents of this information is strictly prohibited and
> against the law.
>
